fix(tests): Fix flaky cart preview test#114387
Merged
Conversation
Move `expect(mockResponse).toHaveBeenCalled()` after the `waitFor` content assertion. The Cart component's preview fetch depends on billing details loading first (async chain), so the mock may not be called by the time `findByTestId` resolves. Waiting for the content to appear guarantees the mock was called.
github-actions
Bot
added
the
Scope: Frontend
brendanhsentry
approved these changes
Apr 29, 2026
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
static/gsApp/views/amCheckout/components/cart.spec.tsx("Cart > renders preview data")expect(mockResponse).toHaveBeenCalled()assertion was firing before the Cart component's async preview fetch completedwaitForcontent check, which guarantees the mock was calledRoot Cause
The Cart component has an async dependency chain before fetching preview data:
useBillingDetails()loads async →hasCompleteBillingInfo→shouldDisableCheckout→fetchPreviewundefined, soshouldDisableCheckout=trueand preview fetch is skippedfindByTestId('summary-item-due-today')can resolve before the preview mock is called, causing the baretoHaveBeenCalled()to fail intermittentlyTest plan