ref(tsc): insights useReleases to apiOptions#114411
Merged
Conversation
Replace the manual `[getApiUrl(...), {query}]` v1 query key + custom
`api.requestPromise` queryFn with `apiOptions.as<TableData>()(...)` wrapped in
`queryOptions(...)`. The default `selectJson` returns `TableData` directly so
consumer access patterns (`c.data?.data`) remain unchanged.
Drops now-unused imports: `getApiUrl`, `parseQueryKey`, `ApiQueryKey`, `useApi`.
Co-Authored-By: Claude <noreply@anthropic.com>
JonasBa
approved these changes
Apr 30, 2026
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Migrate the insights `useReleases` hook from a manually-built v1 query
key + custom `api.requestPromise` queryFn to
`apiOptions.as<TableData>()(...)` wrapped in `queryOptions(...)`.
The original was working around the absence of `apiOptions` by building
`[getApiUrl(...), {query}]` and then re-deriving `{url, options}` via
`parseQueryKey` to call `api.requestPromise` by hand. With `apiOptions`,
the URL and options live in one place and the default `selectJson`
returns `TableData` to the consumer — so the existing
`c.data?.data?.forEach` access pattern below the `useQueries` call stays
identical.
Drops now-unused imports: `getApiUrl`, `parseQueryKey`, `ApiQueryKey`,
`useApi`. No behavior change.
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the insights
useReleaseshook from a manually-built v1 query key + customapi.requestPromisequeryFn toapiOptions.as<TableData>()(...)wrapped inqueryOptions(...).The original was working around the absence of
apiOptionsby building[getApiUrl(...), {query}]and then re-deriving{url, options}viaparseQueryKeyto callapi.requestPromiseby hand. WithapiOptions, the URL and options live in one place and the defaultselectJsonreturnsTableDatato the consumer — so the existingc.data?.data?.forEachaccess pattern below theuseQueriescall stays identical.Drops now-unused imports:
getApiUrl,parseQueryKey,ApiQueryKey,useApi. No behavior change.