Skip to content

fix(autofix): Handle errors in code generation better#114423

Merged
Zylphrex merged 3 commits intomasterfrom
txiao/fix/handle-errors-in-code-generation-better
Apr 30, 2026
Merged

fix(autofix): Handle errors in code generation better#114423
Zylphrex merged 3 commits intomasterfrom
txiao/fix/handle-errors-in-code-generation-better

Conversation

@Zylphrex
Copy link
Copy Markdown
Member

This ensures that the section status is completed before rendering the file diffs to avoid partial diffs being shown and handle error states better allowing for retries.

This ensures that the section status is completed before rendering the file
diffs to avoid partial diffs being shown and handle error states better allowing
for retries.
@Zylphrex Zylphrex requested a review from a team as a code owner April 30, 2026 14:26
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 30, 2026
Copy link
Copy Markdown
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 720fcfe. Configure here.

Comment thread static/app/components/events/autofix/useExplorerAutofix.tsx Outdated
{t('Re-run')}
</Button>
</div>
</ArtifactDetails>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset prompt unreachable in error state causes stuck button

Low Severity

The AutofixResetPrompt was moved from the top of the non-processing branch into the success-only branch (artifact && patchesByRepo.size). In the error state, clicking the header "Re-run step" button sets shouldShowReset to true, which flips canReset to false (disabling the button), but the prompt never renders because it's in the wrong branch. There's no way to reset shouldShowReset back to false, so the header reset button gets permanently stuck as disabled.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 720fcfe. Configure here.

@Zylphrex Zylphrex merged commit 5fd0221 into master Apr 30, 2026
67 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/handle-errors-in-code-generation-better branch April 30, 2026 15:16
cleptric pushed a commit that referenced this pull request May 5, 2026
This ensures that the section status is completed before rendering the
file diffs to avoid partial diffs being shown and handle error states
better allowing for retries.

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants