feat(ourlogs): switch table expando to visualizations, with collapsed chart previews#114433
Merged
JoshuaKGoldberg merged 7 commits intomasterfrom May 1, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
JoshuaKGoldberg
force-pushed
the
explore-logs-collapsed-summary-visualizations
branch
from
ddb4f4a to
12d6775
Compare
JoshuaKGoldberg
force-pushed
the
explore-logs-collapsed-summary-visualizations
branch
from
12d6775 to
f2a9ccc
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
nsdeschenes
approved these changes
May 1, 2026
Contributor
nsdeschenes
left a comment
nsdeschenes
left a comment
There was a problem hiding this comment.
Looks all good to me 😄
Seems like there are some merge conflicts tho 😢
Member
Author
|
I swear, every time I send something for review... 🫠 (these I think I gave to myself though lol) |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dc82e9a. Configure here.
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
… chart previews (#114433) This applies three changes: * Removes the expando button & the concept of table expansion hiding chart visualizations * Changes chart visualizations to collapsed by default... * ...but with a trimmed-down version of their visualization, and a direct expando button instead of the hamburger menu <table> <thead> <tr> <th>Old Default (Expanded)</th> <th>New Default (Collapsed)</th> </tr> </thead> <tbody> <tr> <td> <img width="1647" height="962" alt="Screenshot of the mobile view shoring an expanded default count(logs). It shows the chart with axis, and the hamburger menu." src="https://github.com/user-attachments/assets/21738cf4-94cd-4931-b534-7ba7bc34b8c8" /> </td> <td> <img width="1647" height="962" alt="Screenshot of the mobile view shoring a collapsed default count(logs). It shows the chart with no axis, and the expando button instead of hamburger menu." src="https://github.com/user-attachments/assets/cdcb6d67-74bb-4670-a427-505aaccd6bd4" /> </td> </tr> </tbody> </table> Fixes LOGS-747
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies three changes:
Fixes LOGS-747