ref(preprod): Update snapshot list framing#114448
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
mtopo27
force-pushed
the
mtopo27/ref/snapshot-list-frame
branch
from
b8e50ba to
4aee09c
Compare
mtopo27
force-pushed
the
mtopo27/ref/snapshot-list-frame
branch
from
4aee09c to
f70da5b
Compare
mtopo27
force-pushed
the
mtopo27/ref/snapshot-list-frame
branch
from
f70da5b to
cb27a7e
Compare
Move snapshot list items into shared group and variant frames so grouped and ungrouped variants follow the same layout. Add a split-view canvas and keep focused view behavior unchanged for the next PR. Co-Authored-By: OpenAI Codex <noreply@openai.com>
mtopo27
force-pushed
the
mtopo27/ref/snapshot-list-frame
branch
from
a844ddb to
fc4b9ca
Compare
NicoHinderling
approved these changes
Apr 30, 2026
mtopo27
added a commit
that referenced
this pull request
May 1, 2026
Keep snapshot group context visible while scrolling long preprod snapshot lists. This stacks on #114448 and adds a pinned group label inside the virtualized list so reviewers can tell which grouped variants are currently in view after the original group header scrolls away. **Virtualized List Header** The pinned label is driven by the active virtual row instead of native sticky positioning inside transformed rows, which avoids moving every mounted group header at once. Refs #114448 --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Refactor the preprod snapshots list so grouped and ungrouped variants share the same parent frame and align more closely with the target Figma layout. This keeps focused view behavior unchanged while setting up the shared framing needed for the follow-up focus-view refactor. **List Frame Layout** Snapshot groups now render through shared group and variant frame primitives. Group headers are contained rows with bottom borders, ungrouped snapshots still get the same parent container, and sibling variants are separated by full-width borders instead of old card gaps. **Split View Canvas** Split diff mode now wraps the base/head columns in a canvas with secondary background and primary border. Branch labels sit at the top of the canvas without their previous bottom border. --------- Co-authored-by: OpenAI Codex <noreply@openai.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Keep snapshot group context visible while scrolling long preprod snapshot lists. This stacks on #114448 and adds a pinned group label inside the virtualized list so reviewers can tell which grouped variants are currently in view after the original group header scrolls away. **Virtualized List Header** The pinned label is driven by the active virtual row instead of native sticky positioning inside transformed rows, which avoids moving every mounted group header at once. Refs #114448 --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the preprod snapshots list so grouped and ungrouped variants share the same parent frame and align more closely with the target Figma layout. This keeps focused view behavior unchanged while setting up the shared framing needed for the follow-up focus-view refactor.
List Frame Layout
Snapshot groups now render through shared group and variant frame primitives. Group headers are contained rows with bottom borders, ungrouped snapshots still get the same parent container, and sibling variants are separated by full-width borders instead of old card gaps.
Split View Canvas
Split diff mode now wraps the base/head columns in a canvas with secondary background and primary border. Branch labels sit at the top of the canvas without their previous bottom border.