Conversation
The current version entry in the Edit History modal was showing the dashboard creator's name/avatar instead of the person who last edited it. The modal was passing `dashboard.createdBy` (the original creator) as the `createdBy` prop for the current version list item. It now uses `revisions[0].createdBy` instead, which is the author of the most recent saved revision. Fixes DAIN-1618 Co-Authored-By: Claude Sonnet 4.6 <noreply@example.com>
github-actions
Bot
added
the
Scope: Frontend
… historical entries The revisionSource for each historical revision entry already uses the following (older) revision's source, because each snapshot is saved before the operation that produces it. The createdBy was using the revision's own createdBy, making the label and the author inconsistent — they described different operations. Apply the same index + 1 offset to createdBy so the label and author always refer to the same operation. Co-Authored-By: Claude Sonnet 4.6 <noreply@example.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@example.com>
gggritso
approved these changes
May 1, 2026
skaasten
deleted the
shaunkaasten/dain-1618-current-version-always-shows-dashboard-creator-instead-of
branch
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
…on (#114471) The Dashboard Revision list was showing the wrong user for the current version and each revision item. For the current version, we were using the dashboard creator, when we should use the user we stored for the first revision (since that's the newest edit). For each historical version in the list, we need to look at the user/edit-source of the next revision, since that's from whom/why a particular revision was made. Fixes DAIN-1618 --------- Co-authored-by: Claude Sonnet 4.6 <noreply@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dashboard Revision list was showing the wrong user for the current version and each revision item.
For the current version, we were using the dashboard creator, when we should use the user we stored for the first revision (since that's the newest edit).
For each historical version in the list, we need to look at the user/edit-source of the next revision, since that's from whom/why a particular revision was made.
Fixes DAIN-1618