feat(search-query-builder): Add highlighted text#114472
Merged
nsdeschenes merged 7 commits intomasterfrom May 4, 2026
Merged
Conversation
Add shared substring highlighting for search query builder suggestions and apply it to filter key matches. Keep fuzzy-only matches unhighlighted so the visual emphasis matches the typed substring.
Apply suggestion substring highlighting to filter value options. Cover both single-value edits and multi-select values so the highlighted match follows the active input text.
github-actions
Bot
added
the
Scope: Frontend
rbro112
added a commit
that referenced
this pull request
May 1, 2026
Had an issue where #114472 shows many snapshots removed. Upon further investigation, this was because the baseSha is being set to the tip of master (`1cfab7e`) and not the true merge base. This forces the use of the merge-base to avoid issues.
Assert the aggregate suggestion by option name so highlighted label markup does not break the test. Co-Authored-By: OpenAI Codex <noreply@openai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c2411f8. Configure here.
narsaynorath
approved these changes
May 4, 2026
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Had an issue where #114472 shows many snapshots removed. Upon further investigation, this was because the baseSha is being set to the tip of master (`1cfab7e`) and not the true merge base. This forces the use of the merge-base to avoid issues.
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Small tweak to the search query builder to highlight matching text to make it stand out more. --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small tweak to the search query builder to highlight matching text to make it stand out more.
Example: