ref(seer-agent): Use Link component to enable cmd clicking tool links#114494
Merged
ref(seer-agent): Use Link component to enable cmd clicking tool links#114494
Conversation
Replace the custom button+navigate pattern with the Link component from @sentry/scraps/link. This gives cmd/ctrl+click to open in a new tab for free, removes the manual modifier-key handling, and simplifies the click handler to only fire analytics. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
aliu39
changed the title
JonasBa
approved these changes
Apr 30, 2026
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
…#114494) ## Summary https://github.com/user-attachments/assets/de723eb3-3130-4484-aaed-75a1998fdb5d - Replaces the styled `button` + manual `navigate()` pattern on tool call links with `Link` from `@sentry/scraps/link` - cmd/ctrl+click now works natively (opens in a new tab) since `Link` renders a proper `<a>` with `href` - Click handler is simplified to only stop propagation and fire the analytics event — all navigation is deferred to the `Link` component ## Test plan - [x] Click a tool call link — should navigate client-side as before - [x] cmd+click / ctrl+click a tool call link — should open in a new tab --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screen.Recording.2026-04-30.at.3.15.07.PM.mov
button+ manualnavigate()pattern on tool call links withLinkfrom@sentry/scraps/linkLinkrenders a proper<a>withhrefLinkcomponentTest plan