ref(snapshots): Share focused snapshot card frames#114498
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
mtopo27
force-pushed
the
mtopo27/ref/snapshot-focused-view
branch
from
432d4e8 to
8b65e2d
Compare
Move the focused snapshot shell onto the shared card and variant frame primitives while preserving its toolbar, dark preview handling, scroll body, and navigation controls. Co-Authored-By: Codex <noreply@openai.com>
Thread the focused head branch label into split, wipe, and onion diff views so the head side no longer uses a hardcoded branch name. Co-Authored-By: Codex <noreply@openai.com>
Move renamed snapshot list variants onto the single-image card path while keeping the full rename pair available to metadata copy. Co-Authored-By: Codex <noreply@openai.com>
Add focused main-content coverage for changed diff controls, navigation state, and renamed single-image metadata behavior. Co-Authored-By: Codex <noreply@openai.com>
mtopo27
force-pushed
the
mtopo27/ref/snapshot-focused-view
branch
from
458601f to
016051b
Compare
NicoHinderling
approved these changes
May 1, 2026
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Make the focus view look like list view. prod <img width="2022" height="1400" alt="CleanShot 2026-05-01 at 00 23 55@2x" src="https://github.com/user-attachments/assets/2bfecff0-1f0a-4200-afad-2b8e9c3d1967" /> pr <img width="2040" height="1398" alt="CleanShot 2026-05-01 at 00 24 06@2x" src="https://github.com/user-attachments/assets/3037d178-b040-4891-9fe8-ff0e5361672c" /> --- Share the snapshot card and variant frames between list and focused snapshot views so focused diffs inherit the same grouping and fill-height behavior. This also fixes the focused diff branch label and renders renamed snapshots as a single image with the existing card metadata. **Focused Snapshot Frames** The focused view now composes `SnapshotCardFrame` and `SnapshotVariantFrame` instead of maintaining a separate card/group wrapper, keeping the layout behavior aligned with the list view. **Focused View Coverage** Adds React tests for changed and renamed focused snapshot states, including diff controls, navigation state, and metadata copying. --------- Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the focus view look like list view.
prod
pr
Share the snapshot card and variant frames between list and focused snapshot views so focused diffs inherit the same grouping and fill-height behavior. This also fixes the focused diff branch label and renders renamed snapshots as a single image with the existing card metadata.
Focused Snapshot Frames
The focused view now composes
SnapshotCardFrameandSnapshotVariantFrameinstead of maintaining a separate card/group wrapper, keeping the layout behavior aligned with the list view.Focused View Coverage
Adds React tests for changed and renamed focused snapshot states, including diff controls, navigation state, and metadata copying.