Skip to content

feat(ACI): Hide team metric alerts triggered component in workflow engine UI#114504

Merged
ceorourke merged 1 commit intomasterfrom
ceorourke/ISWF-2573
Apr 30, 2026
Merged

feat(ACI): Hide team metric alerts triggered component in workflow engine UI#114504
ceorourke merged 1 commit intomasterfrom
ceorourke/ISWF-2573

Conversation

@ceorourke
Copy link
Copy Markdown
Member

This component hasn't been able to load because it relies on incident data that we no longer write - however it's in a rather buried page and we haven't heard anything from customers about it not working. We're going to hide it behind the workflow engine ui flag (which is being GA'd next week) and see if anyone notices / cares. If they do, we can work on updating it with ACI data.

without (local)
Screenshot 2026-04-30 at 3 03 56 PM
with (local, no alerts to be spoken of)
Screenshot 2026-04-30 at 3 06 29 PM
with (prod, there are alerts but it spins until it times out)
Screenshot 2026-04-30 at 3 09 59 PM

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 30, 2026

@ceorourke ceorourke requested a review from a team April 30, 2026 22:11
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 30, 2026
@ceorourke ceorourke requested a review from souredoutlook April 30, 2026 22:11
Copy link
Copy Markdown
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for now, nothing is better than broken. we can also always revisit this and just update to use workflow fire history.

'Alerts triggered from the Alert Rules your team created.'
)}
>
<TeamAlertsTriggered
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 should we just update the url to get the workflow fire histories?

not sure how many folks use this page / data. it doesn't seem like a lot since it's broken tho...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that was our thought (Nick and I), see if anyone even notices it's gone and if they do we can update

@ceorourke ceorourke merged commit 8e71bc2 into master Apr 30, 2026
72 checks passed
@ceorourke ceorourke deleted the ceorourke/ISWF-2573 branch April 30, 2026 22:49
cleptric pushed a commit that referenced this pull request May 5, 2026
…gine UI (#114504)

This component hasn't been able to load because it relies on incident
data that we no longer write - however it's in a rather buried page and
we haven't heard anything from customers about it not working. We're
going to hide it behind the workflow engine ui flag (which is being GA'd
next week) and see if anyone notices / cares. If they do, we can work on
updating it with ACI data.

**without (local)**
<img width="1085" height="716" alt="Screenshot 2026-04-30 at 3 03 56 PM"
src="https://github.com/user-attachments/assets/b38b7585-bb13-4f45-94f2-814db3fe0ede"
/>
**with (local, no alerts to be spoken of)**
<img width="705" height="720" alt="Screenshot 2026-04-30 at 3 06 29 PM"
src="https://github.com/user-attachments/assets/ad0ca1f9-e531-43f2-b3cc-b1773da8bbf7"
/>
**with (prod, there are alerts but it spins until it times out)**
<img width="1379" height="273" alt="Screenshot 2026-04-30 at 3 09 59 PM"
src="https://github.com/user-attachments/assets/e0eed8cd-7302-49e5-9d8e-c495041cefc2"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants