fix(types): Remove sentry.api.paginator from mypy ignore list#114510
Merged
fix(types): Remove sentry.api.paginator from mypy ignore list#114510
Conversation
github-actions
Bot
added
the
Scope: Backend
kcons
commented
May 1, 2026
|
|
||
|
|
||
| def count_hits(queryset, max_hits): | ||
| def count_hits(queryset: Any, max_hits: int) -> int: |
Member
Author
There was a problem hiding this comment.
this is hard to make precise because it depends on our queryset subclass which isn't returned by common methods according to stubs. It'll be cleaned up in another pass.
kcons
commented
May 1, 2026
| return int(math.floor(value) if self._is_asc(for_prev) else math.ceil(value)) | ||
|
|
||
| def value_from_cursor(self, cursor): | ||
| def value_from_cursor(self, cursor: Cursor) -> datetime: # type: ignore[override] |
Member
Author
There was a problem hiding this comment.
This is some weirdness that is correct at runtime but an odd fit for our abstractions.
kcons
commented
May 1, 2026
|
|
||
| # offset = "page" number * max number of items per page | ||
| fetch_offset = cursor.offset * cursor.value | ||
| assert isinstance(cursor.value, (int, float)) |
Member
Author
There was a problem hiding this comment.
the riskiest bit, but it basically has to be numeric, so should be fine.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0490d71. Configure here.
joshuarli
approved these changes
May 1, 2026
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
Not yet stronglist-level, but at least not ignored. Fixes ENG-6445.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet stronglist-level, but at least not ignored.
Fixes ENG-6445.