Skip to content

fix(seer): Tidy up the workflows table#114545

Merged
trevor-e merged 6 commits intomasterfrom
trevor-e/fix/seer-workflows-table-clipping
May 1, 2026
Merged

fix(seer): Tidy up the workflows table#114545
trevor-e merged 6 commits intomasterfrom
trevor-e/fix/seer-workflows-table-clipping

Conversation

@trevor-e
Copy link
Copy Markdown
Member

@trevor-e trevor-e commented May 1, 2026

A few small fixes to the /seer/workflows/ table:

Cap the table at 60% on wide screens

The original 50% cap squeezed the table on its own but kept room for the Ask Seer drawer to sit beside it. 60% gives the table more breathing room while still leaving the drawer space.

Drop the Status column, surface errors inline

The Status column showed "Completed" the entire time a run was executing, which was a lie — the row is created at the start of the run and the only completion-adjacent backend signal we have is error_message. The Explorer link already covers "is something happening" for in-flight runs, so the column wasn't earning its keep. When a run errors, the message now renders inline in the Issues cell.

Move Explorer to the first column after the chevron

It's the most useful action on each row, so put it where you don't have to look for it.

Stacked on #114544.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 1, 2026
@trevor-e trevor-e changed the title fix(seer): Stop clipping the workflows table on wide screens fix(seer): Tidy up the workflows table May 1, 2026
Base automatically changed from trevor-e/fix/seer-night-shift-early-persist-agent-run-id to master May 1, 2026 09:44
@chromy chromy requested a review from a team as a code owner May 1, 2026 09:44
Copy link
Copy Markdown
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

trevor-e and others added 5 commits May 1, 2026 13:30
agentic_triage_strategy lives under tasks/seer/night_shift/ and is only
ever called from the night shift cron, so the callback-based decoupling
from SeerNightShiftRun wasn't earning its keep. Take the run directly
and persist agent_run_id in place — fewer indirections, the cron call
site collapses back to a one-liner.

Co-Authored-By: Claude <noreply@anthropic.com>
There's only one caller and it always has a run, so the Optional was
unnecessary defensive coding. Drop the None default and the
corresponding null check.

Co-Authored-By: Claude <noreply@anthropic.com>
The added paragraph just narrated what the code shows.

Co-Authored-By: Claude <noreply@anthropic.com>
The container capped the table at 50% of the viewport at lg+ breakpoints,
which squeezed the 9-column layout and clipped content on full-width
windows. Let the table fill the available width instead.

Co-Authored-By: Claude <noreply@anthropic.com>
The Status column showed "Completed" the entire time a run was executing,
which was a lie — the row was created at the start of the run and the only
backend signal we have is the error message. The Explorer link covers the
"is something happening" question, so just remove the column. When a run
errored, surface the message inline in the Issues cell instead of hiding
it behind a row expansion.

Co-Authored-By: Claude <noreply@anthropic.com>
@chromy chromy force-pushed the trevor-e/fix/seer-workflows-table-clipping branch from b794720 to 287c74d Compare May 1, 2026 12:31
Re-cap the workflows table at 60% on lg+ so the Ask Seer drawer can sit
beside it instead of overlapping. Move the Explorer link to be the first
column after the expand chevron — it's the most useful action on each
row, so put it where you don't have to look for it.

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9ce6a58. Configure here.

Comment thread static/app/views/seerWorkflows/index.tsx
@trevor-e trevor-e merged commit 641373e into master May 1, 2026
72 checks passed
@trevor-e trevor-e deleted the trevor-e/fix/seer-workflows-table-clipping branch May 1, 2026 16:43
cleptric pushed a commit that referenced this pull request May 5, 2026
A few small fixes to the `/seer/workflows/` table:

**Cap the table at 60% on wide screens**

The original 50% cap squeezed the table on its own but kept room for the
Ask Seer drawer to sit beside it. 60% gives the table more breathing
room while still leaving the drawer space.

**Drop the Status column, surface errors inline**

The Status column showed "Completed" the entire time a run was
executing, which was a lie — the row is created at the start of the run
and the only completion-adjacent backend signal we have is
`error_message`. The Explorer link already covers "is something
happening" for in-flight runs, so the column wasn't earning its keep.
When a run errors, the message now renders inline in the Issues cell.

**Move Explorer to the first column after the chevron**

It's the most useful action on each row, so put it where you don't have
to look for it.

Stacked on #114544.

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants