fix(slot): prefer graceful degradation when slot not found#114547
Merged
natemoo-re merged 5 commits intomasterfrom May 1, 2026
Merged
fix(slot): prefer graceful degradation when slot not found#114547natemoo-re merged 5 commits intomasterfrom
natemoo-re merged 5 commits intomasterfrom
Conversation
github-actions
Bot
added
the
Scope: Frontend
JonasBa
approved these changes
May 1, 2026
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
By switching to graceful degradation (render nothing outside of context), we no longer see the "SlotContext not found" error captured by parent ErrorBoundaries during `dev` because of HMR However, considering that we've seen this class of error in prod, we should capture an issue in Sentry when this happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By switching to graceful degradation (render nothing outside of context), we no longer see the "SlotContext not found" error captured by parent ErrorBoundaries during
devbecause of HMRHowever, considering that we've seen this class of error in prod, we should capture an issue in Sentry when this happens.