Skip to content

ref(dashboards): Inline top_n -> area conversion into widget library templates#114563

Merged
DominikB2014 merged 1 commit intomasterfrom
dominikb2014/ref/inline-top-n-conversion-in-widget-library
May 1, 2026
Merged

ref(dashboards): Inline top_n -> area conversion into widget library templates#114563
DominikB2014 merged 1 commit intomasterfrom
dominikb2014/ref/inline-top-n-conversion-in-widget-library

Conversation

@DominikB2014
Copy link
Copy Markdown
Contributor

The three top_n widget library templates (high-throughput-transactions x2 and top-unhandled) are now defined as area with limit: 5 directly, instead of top_n plus a runtime converter. Users already saw the converted form via getTopNConvertedDefaultWidgets, so this is a no-op for them; it removes an indirection now that the builder no longer creates top_n widgets at all.

Pairs with the data backfill in #114560, but doesn't depend on it — both can land in either order.

…templates

Define the three previously-top_n library templates as area + limit=5
directly, and remove getTopNConvertedDefaultWidgets in favor of
exporting getDefaultWidgets. Templates already rendered as area at
runtime via the converter, so this is a no-op for users; it just
removes an indirection now that the builder no longer creates top_n
widgets.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 1, 2026
@DominikB2014 DominikB2014 marked this pull request as ready for review May 1, 2026 16:50
@DominikB2014 DominikB2014 requested a review from a team as a code owner May 1, 2026 16:50
@DominikB2014 DominikB2014 merged commit e97d75c into master May 1, 2026
71 of 72 checks passed
@DominikB2014 DominikB2014 deleted the dominikb2014/ref/inline-top-n-conversion-in-widget-library branch May 1, 2026 16:59
cleptric pushed a commit that referenced this pull request May 5, 2026
…templates (#114563)

The three `top_n` widget library templates
(`high-throughput-transactions` x2 and `top-unhandled`) are now defined
as `area` with `limit: 5` directly, instead of `top_n` plus a runtime
converter. Users already saw the converted form via
`getTopNConvertedDefaultWidgets`, so this is a no-op for them; it
removes an indirection now that the builder no longer creates `top_n`
widgets at all.

Pairs with the data backfill in #114560, but doesn't depend on it — both
can land in either order.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants