ref(spans): clean up enforce-segment-size option#114593
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dadc98a. Configure here.
| root_timeout = options.get("spans.buffer.root-timeout") | ||
| max_spans_per_evalsha = options.get("spans.buffer.max-spans-per-evalsha") | ||
| max_segment_bytes = options.get("spans.buffer.max-segment-bytes") | ||
| enforce_segment_size = options.get("spans.buffer.enforce-segment-size") |
Contributor
There was a problem hiding this comment.
Unused option registration left behind during cleanup
Low Severity
This PR removes all reads of the spans.buffer.enforce-segment-size option from buffer.py and tests, but the option is still registered in src/sentry/options/defaults.py (line 3236). Since the cleanup is the explicit goal of this PR, the registration and its comment in defaults.py are now dead code and could be removed alongside these changes.
Reviewed by Cursor Bugbot for commit dadc98a. Configure here.
untitaker
approved these changes
May 4, 2026
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
We have rolled out the flag in all regions and the spans buffer is stable. We can start cleaning up the flag and default to the new enforce max-segment-bytes subsegment detaching behaviour in the Lua script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have rolled out the flag in all regions and the spans buffer is stable. We can start cleaning up the flag and default to the new enforce max-segment-bytes subsegment detaching behaviour in the Lua script.