fix(tests): deflake projectQuickLinks tests#114631
Merged
Conversation
Wrap router.location assertions in waitFor after userEvent.click to handle async route updates. Remove unnecessary click before hover in the tooltip test to prevent race conditions. Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
github-actions
Bot
added
the
Scope: Frontend
ryan953
added
the
Frontend: Rerun Flaky Tests
scttcper
approved these changes
May 1, 2026
3 tasks
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
## Summary - Wrap `router.location` assertions in `waitFor` after `userEvent.click` to handle async route updates that were causing flaky failures in the "renders a list" test. - Remove unnecessary `userEvent.click` before `userEvent.hover` in the "disables link if feature is missing" test to eliminate tooltip race conditions. - Add `waitFor` to imports. ## Test plan - [ ] CI passes for `static/app/views/projectDetail/projectQuickLinks.spec.tsx` Co-authored-by: Claude Opus 4.6 <noreply@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
router.locationassertions inwaitForafteruserEvent.clickto handle async route updates that were causing flaky failures in the "renders a list" test.userEvent.clickbeforeuserEvent.hoverin the "disables link if feature is missing" test to eliminate tooltip race conditions.waitForto imports.Test plan
static/app/views/projectDetail/projectQuickLinks.spec.tsx