ref(onboarding): Enforce display order for SCM provider pills#114727
Merged
ref(onboarding): Enforce display order for SCM provider pills#114727
Conversation
The integrations endpoint returns providers ordered by name, which sorts the primary onboarding pills as Bitbucket, GitHub, GitLab. Drive the pill order from the PRIMARY_PROVIDER_KEYS array so they always render as GitHub, GitLab, Bitbucket regardless of API order.
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.40% |
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
## Summary
The `/organizations/{slug}/integrations/` endpoint orders providers
alphabetically by name, which renders the primary onboarding pills as
Bitbucket, GitHub, GitLab. Drive the pill order from the
`PRIMARY_PROVIDER_KEYS` array instead so the SCM connect step always
shows GitHub, GitLab, Bitbucket.
The "More" dropdown is unaffected and continues to display in the order
returned by the API.
## Test plan
- [ ] `CI=true pnpm test
static/app/views/onboarding/components/scmProviderPills.spec.tsx` passes
(5 tests, including a new ordering test)
- [ ] Visit the onboarding SCM connect step locally and confirm pill
order is GitHub, GitLab, Bitbucket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/organizations/{slug}/integrations/endpoint orders providers alphabetically by name, which renders the primary onboarding pills as Bitbucket, GitHub, GitLab. Drive the pill order from thePRIMARY_PROVIDER_KEYSarray instead so the SCM connect step always shows GitHub, GitLab, Bitbucket.The "More" dropdown is unaffected and continues to display in the order returned by the API.
Test plan
CI=true pnpm test static/app/views/onboarding/components/scmProviderPills.spec.tsxpasses (5 tests, including a new ordering test)