Skip to content

fix(breadcrumbs): align severity level label with title#114745

Merged
cvxluo merged 1 commit intomasterfrom
cvxluo/align-level-label-with-title-in-timeline-header
May 4, 2026
Merged

fix(breadcrumbs): align severity level label with title#114745
cvxluo merged 1 commit intomasterfrom
cvxluo/align-level-label-with-title-in-timeline-header

Conversation

@cvxluo
Copy link
Copy Markdown
Contributor

@cvxluo cvxluo commented May 4, 2026

Align the 'error', 'info' severity text with the header. I suspect something regressed recently but couldn't find anything — there's also probably a better way to align these, but this seems slightly better than before.

Before:
Screenshot 2026-05-04 at 10 58 48 AM

After:
Screenshot 2026-05-04 at 10 58 58 AM

Co-authored-by: Claude <noreply@anthropic.com>
@cvxluo cvxluo marked this pull request as ready for review May 4, 2026 18:00
@cvxluo cvxluo requested review from a team May 4, 2026 18:00
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

📊 Type Coverage Diff

Metric Before After Delta
Coverage 93.37% 93.40% 🟢 +0.03%
Typed 134,662 134,836 🟢 +174
Untyped 9,568 9,525 🟢 -43
🔍 13 new type safety issues introduced

any-typed symbols (6 new)

File Line Detail
static/app/components/commandPalette/ui/cmdk.tsx 54 CMDKCollection (var)
static/app/components/modals/addTempestCredentialsModal.tsx 67 error (param)
static/app/components/searchQueryBuilder/tokens/filter/valueCombobox.tsx 416 label (var)
static/app/views/detectors/components/forms/common/editableDetectorName.tsx 11 onChange (param(binding))
static/app/views/detectors/components/forms/common/editableDetectorName.tsx 11 value (param(binding))
static/app/views/detectors/components/forms/common/editableDetectorName.tsx 11 <pattern> (param)

Non-null assertions (!) (3 new)

File Line Detail
static/app/views/preprod/snapshots/snapshots.tsx 359 byType.get(type)!
static/app/views/preprod/snapshots/snapshots.tsx 360 byType.get(type)!
static/app/views/settings/organizationRepositoriesV2/index.tsx 227 installationsByProviderKey[provider.key]!

Type assertions (as) (4 new)

File Line Detail
static/app/views/explore/tables/aggregateColumnEditorModal.tsx 631 as AggregationKeyfunctionName as AggregationKey
static/app/views/explore/utils/findFreshEmptyPrefixSearchCacheMatch.ts 46 `as ApiResponse<unknown[]>
static/app/views/explore/utils/findFreshEmptyPrefixSearchCacheMatch.ts 48 as ApiResponse<never[]>data as ApiResponse<never[]>
static/app/views/explore/utils/findFreshEmptyPrefixSearchCacheMatch.ts 84 as Record<string, unknown>value as Record<string, unknown>

This is informational only and does not block the PR.

Copy link
Copy Markdown
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cvxluo cvxluo merged commit ae8f7a5 into master May 4, 2026
73 of 74 checks passed
@cvxluo cvxluo deleted the cvxluo/align-level-label-with-title-in-timeline-header branch May 4, 2026 18:16
cleptric pushed a commit that referenced this pull request May 5, 2026
Align the 'error', 'info' severity text with the header. I suspect
something regressed recently but couldn't find anything — there's also
probably a better way to align these, but this seems slightly better
than before.

Before:
<img width="262" height="67" alt="Screenshot 2026-05-04 at 10 58 48 AM"
src="https://github.com/user-attachments/assets/34ed9263-1695-4fae-8e1f-7d01f66336f8"
/>

After:
<img width="259" height="65" alt="Screenshot 2026-05-04 at 10 58 58 AM"
src="https://github.com/user-attachments/assets/f638aded-070e-4d69-ab53-cc0c29ad763a"
/>

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants