ref(grouping): Correctly parameterize dotted ints#114776
Merged
lobsterkatie merged 2 commits intomasterfrom May 4, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
wedamija
approved these changes
May 4, 2026
lobsterkatie
changed the title
lobsterkatie
deleted the
kmclb-fix-float-and-ip-parameterization-regexes-to-only-have-two-or-four-parts
branch
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
This fixes our IPv4 and float parameterization regexes so that IPv4 values must have exactly 4 dotted segments, and floats must have exactly 2. (Currently, `1.2.3.4.5` matches as `<ip>.<int>` and `1.2.3` matches as `<float>.<int>`.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes our IPv4 and float parameterization regexes so that IPv4 values must have exactly 4 dotted segments, and floats must have exactly 2. (Currently,
1.2.3.4.5matches as<ip>.<int>and1.2.3matches as<float>.<int>.)