ref(seer): Genericize night shift result table by trevor-e · Pull Request #114790 · getsentry/sentry

trevor-e · 2026-05-04T22:15:32Z

Repurposes the existing night-shift result table so it can host more than just agentic triage. No behavior change.

Renames SeerNightShiftRunIssue → SeerNightShiftRunResult (state-only via SeparateDatabaseAndState + RenameModel; underlying Postgres table keeps the historical seer_nightshiftrunissue name).
Adds a kind discriminator (with a NightShiftRunResultKind enum) and a per-row extras JSON.
Migrates action, error_message, and triage_strategy data into JSON (extras) and marks the legacy columns SafeRemoveField(MOVE_TO_PENDING). Physical drop ships in a follow-up.
Serializer keeps issues, triageStrategy, and errorMessage aliases for the existing frontend; new results key is the canonical shape going forward.

Renames SeerNightShiftRunIssue → SeerNightShiftRunResult (state-only; db_table preserved) and adds a `kind` discriminator + per-row `extras` JSON to support nightly per-org work beyond agentic triage. Triage's existing `action` column is moved into extras["action"] via a deploy-time backfill. Legacy columns (action, triage_strategy, error_message) are marked SafeRemoveField MOVE_TO_PENDING; their physical drop ships in a follow-up.

github-actions · 2026-05-04T22:23:22Z

This PR has a migration; here is the generated SQL for src/sentry/seer/migrations/0009_genericize_night_shift_results.py

for 0009_genericize_night_shift_results in seer

--
-- Custom state/database change combination
--
-- (no-op)
--
-- Alter field run on seernightshiftrunresult
--
-- (no-op)
--
-- Add field kind to seernightshiftrunresult
--
ALTER TABLE "seer_nightshiftrunissue" ADD COLUMN "kind" varchar(256) DEFAULT 'agentic_triage' NOT NULL;
--
-- Add field extras to seernightshiftrunresult
--
ALTER TABLE "seer_nightshiftrunissue" ADD COLUMN "extras" jsonb DEFAULT '{}'::jsonb NOT NULL;
--
-- Alter field group on seernightshiftrunresult
--
ALTER TABLE "seer_nightshiftrunissue" ALTER COLUMN "group_id" DROP NOT NULL;
--
-- Alter field action on seernightshiftrunresult
--
ALTER TABLE "seer_nightshiftrunissue" ALTER COLUMN "action" DROP NOT NULL;
--
-- Alter field triage_strategy on seernightshiftrun
--
ALTER TABLE "seer_nightshiftrun" ALTER COLUMN "triage_strategy" DROP NOT NULL;
--
-- Create index seer_nights_run_id_d5406e_idx on field(s) run, kind of model seernightshiftrunresult
--
CREATE INDEX CONCURRENTLY "seer_nights_run_id_d5406e_idx" ON "seer_nightshiftrunissue" ("run_id", "kind");
--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL
--
-- Moved seernightshiftrunresult.action field to pending deletion state
--
-- (no-op)
--
-- Moved seernightshiftrun.triage_strategy field to pending deletion state
--
-- (no-op)
--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL
--
-- Moved seernightshiftrun.error_message field to pending deletion state
--
-- (no-op)

Without this, runs that had an error_message recorded against the legacy column would return errorMessage: null from the API after the column is removed from model state via SafeRemoveField(MOVE_TO_PENDING). Adds a second RunPython op (run before the error_message SafeRemoveField) and extends the migration test to cover both the existing action backfill and the new error_message backfill.

Mypy flagged the missing annotation on the migration test's setup_before_migration override.

Dropping the db_default in the same migration that adds the NOT NULL column breaks rolling deploys: old replicas still INSERTing without kind would fail with a NOT NULL violation between when the migration applies and when those replicas are replaced. Defer the db_default drop to the follow-up PR2 (the same one that runs SafeRemoveField DELETE for the legacy columns), which already requires PR1 to be fully deployed.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit adea73a. Configure here.}

Pre-migration the triage_strategy column was a required CharField, always set to "agentic_triage" — including for runs that produced no result rows (failed quota check, no eligible projects, dry runs). My earlier serializer change derived the legacy alias from result-row presence, silently flipping triageStrategy to null for those runs. Hardcode it back to "agentic_triage" so the API surface matches the old behavior. Multi-kind serializer logic ships with the feature PR.

The migration has 12 operations including a CONCURRENTLY index, so TestMigrations.setUp's roll-back/forward cycle was hovering at or over CI's 120s fail-slow budget per test. The migration itself is already exercised by: - Direct application against dev DB with real data (47 result rows backfilled correctly). - The full night-shift test suite (49 tests) running against the post-migration schema with --create-db. - The two RunPython callbacks are simple idempotent loops; the cost of an integration test has stopped paying for itself.

This reverts commit f7cd5c3.

Drive-by edit from the original PR1 commit. No reason for it.

trevor-e · 2026-05-05T01:31:13Z

                group=c.group,
-                action=c.action,
                seer_run_id=str(seer_run_id),
+                extras={"action": str(c.action)},


Will have to update our dashboard.

ack, will do

chromy

lgtm

Repurposes the existing night-shift result table so it can host more than just agentic triage. No behavior change. - Renames `SeerNightShiftRunIssue` → `SeerNightShiftRunResult` (state-only via `SeparateDatabaseAndState` + `RenameModel`; underlying Postgres table keeps the historical `seer_nightshiftrunissue` name). - Adds a `kind` discriminator (with a `NightShiftRunResultKind` enum) and a per-row `extras` JSON. - Migrates `action`, `error_message`, and `triage_strategy` data into JSON (`extras`) and marks the legacy columns `SafeRemoveField(MOVE_TO_PENDING)`. Physical drop ships in a follow-up. - Serializer keeps `issues`, `triageStrategy`, and `errorMessage` aliases for the existing frontend; new `results` key is the canonical shape going forward.

**Stacked on #114790** — review and land that one first, then wait for full deploy before merging this. Drops the legacy night-shift columns now that #114790 has fully deployed and all live code has stopped reading/writing them. - `SafeRemoveField(DELETE)` for `seer_nightshiftrunissue.action`, `seer_nightshiftrun.triage_strategy`, and `seer_nightshiftrun.error_message` — physically drops the columns from Postgres. - Drops the `db_default` on `kind` (kept in #114790 to keep INSERTs from old replicas valid mid-rolling-deploy). All live code now specifies `kind` explicitly, so the safety net is no longer needed.

github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 4, 2026

cursor Bot reviewed May 4, 2026

View reviewed changes

Comment thread src/sentry/seer/migrations/0009_genericize_night_shift_results.py

trevor-e mentioned this pull request May 4, 2026

feat(seer): Nightly user-feedback summary as a second night shift kind #114794

Draft

Merge branch 'master' into telkins/night-shift-feedback-summary

13a88f5

vercel Bot deployed to Preview May 4, 2026 22:38 View deployment

cursor Bot reviewed May 4, 2026

View reviewed changes

Comment thread src/sentry/seer/migrations/0009_genericize_night_shift_results.py Outdated

trevor-e added 2 commits May 4, 2026 18:47

fix(seer): Annotate setup_before_migration apps param

30a670f

Mypy flagged the missing annotation on the migration test's setup_before_migration override.

cursor Bot reviewed May 4, 2026

View reviewed changes

Comment thread src/sentry/api/serializers/models/seer_night_shift_run.py Outdated

trevor-e added 4 commits May 4, 2026 19:23

Revert "fix(seer): Drop slow TestMigrations integration test for 0009"

cdeb03e

This reverts commit f7cd5c3.

fix(seer): Restore unrelated SeerNightShiftRun docstring change

c803131

Drive-by edit from the original PR1 commit. No reason for it.

trevor-e commented May 5, 2026

View reviewed changes

trevor-e marked this pull request as ready for review May 5, 2026 01:50

trevor-e requested review from a team as code owners May 5, 2026 01:50

trevor-e mentioned this pull request May 5, 2026

ref(seer): Drop legacy night-shift columns and kind db_default #114828

Merged

chromy approved these changes May 5, 2026

View reviewed changes

trevor-e merged commit edb631e into master May 5, 2026
82 of 83 checks passed

trevor-e deleted the telkins/night-shift-feedback-summary branch May 5, 2026 14:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ref(seer): Genericize night shift result table#114790

ref(seer): Genericize night shift result table#114790
trevor-e merged 9 commits intomasterfrom
telkins/night-shift-feedback-summary

trevor-e commented May 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

trevor-e May 5, 2026

Uh oh!

chromy May 5, 2026

Uh oh!

chromy left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

trevor-e commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trevor-e May 5, 2026

Choose a reason for hiding this comment

Uh oh!

chromy May 5, 2026

Choose a reason for hiding this comment

Uh oh!

chromy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

trevor-e commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 4, 2026 •

edited

Loading