fix(slack): Categorize unrecognized Slack API error codes#114804
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
Member
Author
|
@GabeVillalobos is this an appropriate use of Halt? I think the auth one is most debatable, but if it just means somebody invalidated our token, it's not like we benefit from getting an error report. |
saponifi3d
approved these changes
May 5, 2026
Contributor
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
changes lgtm, and the halt usage makes sense to me -- might be good to confirm with @GabeVillalobos but up to you!
Member
Author
|
Gabe confirmed this seems reasonable in DMs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize most of our currently unrecognized slack errors.
Treat the apparently transient or not-our-issue ones as halts.
Fixes SENTRY-3K72.