Skip to content

ref(flags): Remove organizations:workflow-engine-metric-alert-group-by-creation#114805

Merged
wedamija merged 1 commit into
masterfrom
flag-cleanup/organizations-workflow-engine-metric-alert-group-by-creation
May 21, 2026
Merged

ref(flags): Remove organizations:workflow-engine-metric-alert-group-by-creation#114805
wedamija merged 1 commit into
masterfrom
flag-cleanup/organizations-workflow-engine-metric-alert-group-by-creation

Conversation

@wedamija
Copy link
Copy Markdown
Member

@wedamija wedamija commented May 4, 2026

The flag scanner classified this as flagpole-disabled. The flag gated setting group_by on metric alert queries during creation; with the flag always False, group_by cannot be set via the API.

Simplifies _validate_group_by to always reject group_by, and collapses the 11 feature-on test cases into one that asserts rejection. The group_by model field is preserved for existing stored subscriptions.

@wedamija wedamija requested a review from a team May 4, 2026 23:08
@wedamija wedamija requested a review from a team as a code owner May 4, 2026 23:08
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 4, 2026
@ceorourke ceorourke requested a review from JoshFerge May 4, 2026 23:18
…y-creation

The flag scanner classified this as flagpole-disabled. The flag gated
setting group_by on metric alert queries during creation; with the flag
always False, group_by cannot be set via the API.

Simplifies _validate_group_by to always reject group_by, and collapses
the 11 feature-on test cases into one that asserts rejection. The
group_by model field is preserved for existing stored subscriptions.
@wedamija wedamija force-pushed the flag-cleanup/organizations-workflow-engine-metric-alert-group-by-creation branch from a1259c7 to e0fe67f Compare May 21, 2026 17:36
@wedamija wedamija merged commit 986d1b4 into master May 21, 2026
115 of 117 checks passed
@wedamija wedamija deleted the flag-cleanup/organizations-workflow-engine-metric-alert-group-by-creation branch May 21, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants