ref(flags): Remove organizations:workflow-engine-metric-alert-group-by-creation#114805
Merged
wedamija merged 1 commit intoMay 21, 2026
Conversation
…y-creation The flag scanner classified this as flagpole-disabled. The flag gated setting group_by on metric alert queries during creation; with the flag always False, group_by cannot be set via the API. Simplifies _validate_group_by to always reject group_by, and collapses the 11 feature-on test cases into one that asserts rejection. The group_by model field is preserved for existing stored subscriptions.
a1259c7 to
e0fe67f
Compare
JoshFerge
approved these changes
May 21, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag scanner classified this as flagpole-disabled. The flag gated setting group_by on metric alert queries during creation; with the flag always False, group_by cannot be set via the API.
Simplifies _validate_group_by to always reject group_by, and collapses the 11 feature-on test cases into one that asserts rejection. The group_by model field is preserved for existing stored subscriptions.