fix(ACI): Update detector to be monitor for the UI in issue search#114819
Open
saponifi3d wants to merge 1 commit intojcallender/aci/detector-to-monitor-part-2from
Open
fix(ACI): Update detector to be monitor for the UI in issue search#114819saponifi3d wants to merge 1 commit intojcallender/aci/detector-to-monitor-part-2from
detector to be monitor for the UI in issue search#114819saponifi3d wants to merge 1 commit intojcallender/aci/detector-to-monitor-part-2from
Conversation
github-actions
Bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| @@ -587,9 +587,6 @@ def _get_queryset_conditions( | |||
| "regressed_in_release": QCallbackCondition( | |||
| functools.partial(regressed_in_release_filter, projects=projects) | |||
Contributor
There was a problem hiding this comment.
Bug: Removing the detector search filter alias breaks UI components and user-saved searches that still rely on it, causing them to return empty results.
Severity: HIGH
Suggested Fix
Reinstate the detector search alias to maintain backward compatibility. Alternatively, update all locations that use the detector: keyword, including UI components like ongoingIssues.tsx, and create a data migration to update existing SavedSearches and AlertRules to use the new query format.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/sentry/search/snuba/backend.py#L588
Potential issue: The removal of the `detector` search filter alias will break existing
functionality that relies on it. Specifically, UI components like `ongoingIssues.tsx`
and `openPeriodIssues.tsx` contain hardcoded queries such as `is:unresolved
detector:${detector.id}`. With the alias removed, these queries will be interpreted as a
search for a tag named `detector`, which will not match any issues, causing these
components to display no results. This change also breaks existing user-created
`SavedSearches` and `AlertRules` that use the `detector:` keyword, causing them to fail
silently.
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
Author
There was a problem hiding this comment.
User-saved searches will fail, but this is before launch so we should reduce issues there. We are safe from the UI failing by breaking this work into many PRs.
saponifi3d
force-pushed
the
jcallender/aci/detector-to-monitor-part-2
branch
from
9bbf802 to
0f7123e
Compare
…been safely rolled out
saponifi3d
force-pushed
the
jcallender/aci/detector-to-monitor-part-3
branch
from
fa9babc to
d7470e3
Compare
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Last phase of the rename / cleanup; this will remove the legacy references to detector and only support monitor.