Skip to content

ref(tsc): Migrate sentry-apps endpoints to apiOptions#114834

Merged
TkDodo merged 5 commits intomasterfrom
tkdodo/ref/sentry-apps-to-apiOptions
May 5, 2026
Merged

ref(tsc): Migrate sentry-apps endpoints to apiOptions#114834
TkDodo merged 5 commits intomasterfrom
tkdodo/ref/sentry-apps-to-apiOptions

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented May 5, 2026

Migrate the /organizations/{org}/sentry-apps/ list endpoint and the /sentry-apps/{slug}/ detail endpoint to apiOptions, replacing every useApiQuery / getQueryData / setApiQueryData callsite that touched these keys.

Two shared factories now live in actionCreators/sentryApps.tsx:

  • sentryAppsApiOptions({orgSlug, status?}) for the org-scoped list (used by the developer settings index, the integrations directory, the releases quickstart, and the placeholder lookup in the app detail page).
  • sentryAppApiOptions({appSlug}) for a single app (used by the detail edit page, the dashboard, the integration detailed view, the external install page, and the conditional extra_app query in the integrations directory). Conditional fetches use skipToken instead of enabled.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 5, 2026
@TkDodo
Copy link
Copy Markdown
Collaborator Author

TkDodo commented May 5, 2026

bugbot run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.41%

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ed249a2. Configure here.

@TkDodo TkDodo marked this pull request as ready for review May 5, 2026 08:04
@TkDodo TkDodo requested review from a team as code owners May 5, 2026 08:04
Copy link
Copy Markdown
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@TkDodo TkDodo merged commit 049b953 into master May 5, 2026
73 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/sentry-apps-to-apiOptions branch May 5, 2026 08:45
cleptric pushed a commit that referenced this pull request May 5, 2026
Migrate the `/organizations/{org}/sentry-apps/` list endpoint and the
`/sentry-apps/{slug}/` detail endpoint to `apiOptions`, replacing every
`useApiQuery` / `getQueryData` / `setApiQueryData` callsite that touched
these keys.

Two shared factories now live in `actionCreators/sentryApps.tsx`:

- `sentryAppsApiOptions({orgSlug, status?})` for the org-scoped list
(used by the developer settings index, the integrations directory, the
releases quickstart, and the placeholder lookup in the app detail page).
- `sentryAppApiOptions({appSlug})` for a single app (used by the detail
edit page, the dashboard, the integration detailed view, the external
install page, and the conditional `extra_app` query in the integrations
directory). Conditional fetches use `skipToken` instead of `enabled`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants