ref(trace-details): Remove replacement attribute filtering when conventions flag is off#114944
Draft
obostjancic wants to merge 5 commits intomasterfrom
Draft
ref(trace-details): Remove replacement attribute filtering when conventions flag is off#114944obostjancic wants to merge 5 commits intomasterfrom
obostjancic wants to merge 5 commits intomasterfrom
Conversation
…urce exists When use_sentry_conventions is off, span details unconditionally hid all replacement attributes (e.g. gen_ai.usage.input_tokens, gen_ai.input.messages). This worked during migration when both old and new names coexisted, but once SDKs send only the new names, the data silently disappeared from the span detail view. Now only filter out replacement attributes when their deprecated source is actually present in the response. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Contributor
Backend Test FailuresFailures on
|
Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Base automatically changed from
obostjancic/fix/span-details-missing-replacement-attributes
to
master
May 6, 2026 08:50
…ntions flag is off Stop filtering out replacement attributes when use_sentry_conventions is off. The filtering was meant to avoid showing both deprecated and new attribute names, but with the conventions flag at 0% rollout it caused all replacement attributes to be invisible. Showing both names (minor duplication) is better than silently dropping data. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
c7f3996 to
e042ad9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_sentry_convention_replacement_attributefiltering entirely from theelsebranch (whenuse_sentry_conventionsis off)