ref(types): Add mypy types for sentry.search.snuba.executors#114994
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
saponifi3d
force-pushed
the
jcallender/typing/snuba-executors
branch
from
6e353b3 to
5d456e9
Compare
wedamija
reviewed
May 18, 2026
| @property | ||
| @abstractmethod | ||
| def aggregation_defs(self) -> Sequence[str] | Expression: | ||
| def aggregation_defs(self) -> Mapping[str, Any]: |
Member
There was a problem hiding this comment.
This should be a sequence of Mapping[str, Sequence[str] | Callable] where the callable matches this signature:
sentry/src/sentry/search/snuba/executors.py
Lines 840 to 847 in 35a2aa3
saponifi3d
force-pushed
the
jcallender/typing/snuba-executors
branch
2 times, most recently
from
57db4b1 to
ee4afab
Compare
wedamija
approved these changes
May 19, 2026
The aggregation_defs values are typed as Sequence[str], which does not support the + operator. Wrap in list() before concatenating the alias.
saponifi3d
force-pushed
the
jcallender/typing/snuba-executors
branch
from
c8102a9 to
7d5e167
Compare
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
# Description As part of the backend TSC work we want to add types to everything. This PR will add types to the `sentry.search.snuba.executors` module. [Ticket](https://linear.app/getsentry/issue/ENG-6457/remove-sentrysearchsnubaexecutors-from-ignore-list)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of the backend TSC work we want to add types to everything. This PR will add types to the
sentry.search.snuba.executorsmodule.Ticket