Skip to content

feat(ourlogs): bump export modal select default value from 100 to 500 for release to GA#115008

Merged
JoshuaKGoldberg merged 4 commits into
masterfrom
ourlogs-export-modal-value-tweaks
May 7, 2026
Merged

feat(ourlogs): bump export modal select default value from 100 to 500 for release to GA#115008
JoshuaKGoldberg merged 4 commits into
masterfrom
ourlogs-export-modal-value-tweaks

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

Coming out of discussion with @bcoe and @manessaraj: we'll have the default be 500. Otherwise we're ready to ship 🚀 100k is supported nicely for the current API.

Adding an "include all columns" checkbox will be next, once some backend stress testing is done.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 6, 2026
@JoshuaKGoldberg JoshuaKGoldberg requested a review from manessaraj May 6, 2026 19:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

📊 Type Coverage Diff

Metric Before After Delta
Coverage 93.44% 93.44% ±0%
Typed 135,012 135,016 🟢 +4
Untyped 9,479 9,479 ±0
🔍 2 new type safety issues introduced

Non-null assertions (!) (2 new)

File Line Detail
static/app/views/explore/logs/exports/generateLogExportRowCountOptions.ts 31 rowCountOptions[rowCountOptions.length - 1]!
static/app/views/explore/logs/exports/generateLogExportRowCountOptions.ts 42 rowCountOptions[0]!

This is informational only and does not block the PR.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 6, 2026 19:15
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner May 6, 2026 19:15
Comment thread static/app/views/explore/logs/exports/logsExportModal.tsx Outdated
Comment thread static/app/views/explore/logs/exports/logsExportModal.tsx Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 65fe6db. Configure here.

Comment thread static/app/views/explore/logs/exports/logsExportModal.tsx Outdated
Comment thread static/app/views/explore/logs/exports/logsExportModal.tsx Outdated
@JoshuaKGoldberg JoshuaKGoldberg merged commit d9a0942 into master May 7, 2026
83 of 85 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the ourlogs-export-modal-value-tweaks branch May 7, 2026 14:50
constantinius pushed a commit that referenced this pull request May 8, 2026
… for release to GA (#115008)

Coming out of discussion with @bcoe and @manessaraj: we'll have the
default be 500. Otherwise we're ready to ship 🚀 100k is supported nicely
for the current API.

Adding an "include all columns" checkbox will be next, once some backend
stress testing is done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants