feat(tracemetrics): Lazy load trace details per metric#115066
Merged
nsdeschenes merged 17 commits intoMay 21, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.62% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
nsdeschenes
force-pushed
the
nd/EXP-934/feat-metrics-lazy-load-trace-details-per-metric
branch
from
62dc51e to
bef0a6c
Compare
nsdeschenes
force-pushed
the
nd/EXP-934/feat-metrics-lazy-load-trace-details-per-metric
branch
from
f5a1774 to
585452d
Compare
Convert metric sample row timestamps through the shared table date parser before fetching trace meta. This keeps ISO timestamp rows scoped to the sample time instead of falling back to a stats period query. Update the trace meta hook tests for the new isLoading result field and add regression coverage for the metric detail request timestamp. Co-Authored-By: Codex <noreply@openai.com>
Return an empty details row when an expanded metric sample has no trace detail data, and add regression coverage for the no-data state.
Add the loading state required by trace metadata fixtures and adjust the metric trace detail mock cast so the tests match the hook return type. Refs EXP-934
Render explicit empty states when metric sample attributes or trace summary data are unavailable. Co-Authored-By: Codex <noreply@openai.com>
Use trace meta count helpers when rendering expanded metric sample details so the summary works across trace meta shapes and includes metric counts. Refs EXP-934
Assert expanded metric sample details render normalized trace meta counts and verify merged EAP metric counts through the trace meta helper. Refs EXP-934 Co-Authored-By: OpenAI Codex <noreply@openai.com>
Keep isEAPTraceMeta module-local so Knip no longer reports it as an unused public export. Co-Authored-By: Codex <noreply@openai.com>
Show a trace summary error when trace meta requests fail and keep the expanded row markup valid by wrapping the details error state in a table cell. Co-Authored-By: Codex <noreply@openai.com>
Add coverage for expanded metric sample trace meta failures and trace detail failures using a fixed fixture timestamp. Co-Authored-By: Codex <noreply@openai.com>
nsdeschenes
force-pushed
the
nd/EXP-934/feat-metrics-lazy-load-trace-details-per-metric
branch
from
585452d to
407d6b5
Compare
Contributor
Author
|
@cursor review |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 407d6b5. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…rics-lazy-load-trace-details-per-metric # Conflicts: # static/app/views/explore/metrics/metricInfoTabs/metricDetails.tsx # static/app/views/performance/newTraceDetails/traceApi/useTraceMeta.tsx
Use the active loading state for metric trace detail fetches so disabled TanStack queries can fall through to the empty state. Add coverage for the disabled query case where isPending remains true without an active fetch. Co-Authored-By: Codex <noreply@openai.com>
k-fish
approved these changes
May 21, 2026
nsdeschenes
deleted the
nd/EXP-934/feat-metrics-lazy-load-trace-details-per-metric
branch
natemoo-re
pushed a commit
that referenced
this pull request
May 21, 2026
This PR adds back (sorta) trace info for a given metric, however this time we're loading this data when users expand a metric. Closes EXP-934 --------- Co-authored-by: Codex <noreply@openai.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds back (sorta) trace info for a given metric, however this time we're loading this data when users expand a metric.
Closes EXP-934
Example: