[DO NOT MERGE] test: Validate MOVE_TO_PENDING historical_silo_assignments check#115091
Closed
wedamija wants to merge 1 commit intodanf/move-to-pending-historical-silo-checkfrom
Closed
[DO NOT MERGE] test: Validate MOVE_TO_PENDING historical_silo_assignments check#115091wedamija wants to merge 1 commit intodanf/move-to-pending-historical-silo-checkfrom
wedamija wants to merge 1 commit intodanf/move-to-pending-historical-silo-checkfrom
Conversation
Test PR for #115087 — removes GroupCommitResolution and adds a MOVE_TO_PENDING migration without adding sentry_groupcommitresolution to historical_silo_assignments. Expected to fail CI at the migration replay step with "Cannot determine database for deleted model sentry.GroupCommitResolution". DO NOT MERGE. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
wedamija
changed the base branch from
master
to
danf/move-to-pending-historical-silo-check
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Moved model GroupCommitResolution to pending deletion state
--
-- (no-op) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation test for #115087.
Removes
GroupCommitResolutionand ships aMOVE_TO_PENDINGmigration without addingsentry_groupcommitresolutiontohistorical_silo_assignments. With #115087's check in place, CI is expected to fail during the migration replay step with:If CI fails for this reason, the check works. DO NOT MERGE.