fix(releases): Optimize commit processing with bulk operations and truncation#115174
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(releases): Optimize commit processing with bulk operations and truncation#115174sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
ProcessingDeadlineExceedederror in thesentry.tasks.commits.fetch_commitstask, which occurred when processing releases with a large number of commits.Root Cause:
The
set_commits_on_releasefunction was performing individual database operations (e.g.,Commit.objects.get_or_create,CommitFileChange.objects.bulk_create,ReleaseCommit.objects.create) for each commit within a loop. This N+1 query pattern, combined with scenarios wherepreviousCommitwas not provided (leading to fetching a very large number of commits), caused the task to exceed its 905-second processing deadline.Changes Implemented:
MAX_COMMITS_IN_RELEASE = 1000to cap the number of commits processed for a single release, preventing runaway tasks. A warning is logged if the list is truncated.Commit.objects.get_or_create()and subsequentcommit.update()calls with a singleCommit.objects.bulk_create(ignore_conflicts=True)followed by a batchSELECTto retrieve all commits and aCommit.objects.bulk_update()for any changed fields.CommitFileChangeobjects. Instead of individualbulk_createcalls per commit, all file changes are now collected and inserted in a singleCommitFileChange.objects.bulk_create()operation.ReleaseCommit.objects.create()calls, previously wrapped in per-commit atomic transactions, are now replaced by a singleReleaseCommit.objects.bulk_create(ignore_conflicts=True)for all commits.commit.authorwas accessed for comparison, by batch-loading fallback authors.These changes significantly reduce the number of database queries and overall processing time for
fetch_commits, mitigating theProcessingDeadlineExceedederrors and improving the stability of release processing.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-44HA