fix: mypy-weaklist-stale-on-delete#115213
Merged
Merged
Conversation
pyproject.toml changed, so deleting a Python file without cleaning up its weaklist entry would slip through locally and break the test_stronglist CI check. Extended the hook to also trigger on .py file changes so the validation runs whenever a file deletion could produce a stale entry.
github-actions
Bot
added
the
Scope: Backend
NicoHinderling
approved these changes
May 8, 2026
nikkikapadia
pushed a commit
that referenced
this pull request
May 12, 2026
addresses the issue in #115204 --- The check-mypy-weaklist pre-commit hook only fired when pyproject.toml changed, so deleting a Python file without cleaning up its weaklist entry would slip through locally and break the test_stronglist CI check. Extended the hook to also trigger on .py file changes so the validation runs whenever a file deletion could produce a stale entry.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses the issue in #115204
The check-mypy-weaklist pre-commit hook only fired when pyproject.toml changed, so deleting a Python file without cleaning up its weaklist entry would slip through locally and break the test_stronglist CI check. Extended the hook to also trigger on .py file changes so the validation runs whenever a file deletion could produce a stale entry.