Skip to content

fix(conversations): Quote conversation ID in explore query#115271

Merged
obostjancic merged 2 commits into
masterfrom
ognjenbostjancic/tet-2338-explore-page-breaks-on-slack-conversation-ids
May 12, 2026
Merged

fix(conversations): Quote conversation ID in explore query#115271
obostjancic merged 2 commits into
masterfrom
ognjenbostjancic/tet-2338-explore-page-breaks-on-slack-conversation-ids

Conversation

@obostjancic
Copy link
Copy Markdown
Member

@obostjancic obostjancic commented May 11, 2026

Conversation IDs containing colons (e.g. slack:D0AP8S33J2D:1777059410.613279) break the Explore page because the search query gen_ai.conversation.id:slack:D0A18S33J2D:... is parsed as multiple attribute:value pairs. Wrapping the value in double quotes prevents the colon-delimited ID from being split by the query parser.

Fixes TET-2338

Conversation IDs containing colons (e.g. slack:D0AP8S33J2D:1777059420.613279)
break the Explore page because the query parser interprets colons as
attribute:value separators. Wrapping the value in quotes prevents this.

Refs TET-2338
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 11, 2026

TET-2338

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.47%

@obostjancic obostjancic marked this pull request as ready for review May 11, 2026 14:39
@obostjancic obostjancic requested a review from a team as a code owner May 11, 2026 14:39
Comment thread static/app/views/explore/conversations/components/conversationSummary.tsx Outdated
@obostjancic obostjancic enabled auto-merge (squash) May 12, 2026 08:21
@obostjancic obostjancic merged commit 197a704 into master May 12, 2026
75 checks passed
@obostjancic obostjancic deleted the ognjenbostjancic/tet-2338-explore-page-breaks-on-slack-conversation-ids branch May 12, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants