fix(source-maps): Hide docs links for non-JS projects#115302
Open
a-hariti wants to merge 2 commits into
Open
Conversation
Only show Source Maps documentation links when the project platform maps to a JavaScript source-map guide. Non-JS projects keep the Source Maps settings page visible without linking to unrelated JavaScript docs (for now).
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only show Source Maps documentation links when the project platform maps to a JavaScript source-map guide.
Non-JS projects keep the Source Maps settings page visible without linking to unrelated JavaScript docs (for now).
We should probably hide the Sourcemaps setting from the sidebar altogether when it's not relevant. I wanted to keep the diff minimal and mitigate this confusion for now.
Example Python Project
Example Javascript Project
Closes getsentry/sentry-docs#16226
Closes getsentry/sentry-docs#15602
Closes getsentry/sentry-docs#14422
Closes getsentry/sentry-docs#15528
Closes getsentry/sentry-docs#14771
Closes getsentry/sentry-docs#14826
Closes getsentry/sentry-docs#14680
Closes getsentry/sentry-docs#16532
Closes getsentry/sentry-docs#16263
Closes getsentry/sentry-docs#16014
Closes getsentry/sentry-docs#15903
Closes getsentry/sentry-docs#15249