Skip to content

feat(snapshots): Add frontend logic for downloading images zip#115338

Merged
NicoHinderling merged 1 commit into
masterfrom
05-11-feat_snapshots_add_frontend_logic_for_downloading_images_zip
May 12, 2026
Merged

feat(snapshots): Add frontend logic for downloading images zip#115338
NicoHinderling merged 1 commit into
masterfrom
05-11-feat_snapshots_add_frontend_logic_for_downloading_images_zip

Conversation

@NicoHinderling
Copy link
Copy Markdown
Contributor

@NicoHinderling NicoHinderling commented May 11, 2026

Screenshots:
image

image

Summary

Frontend companion to #115337. Adds a "Download Images" action to the snapshot header dropdown menu that fetches the zip from the new download endpoint and triggers a browser download.

Also cleans up the SnapshotImage type and test fixtures:

  • Removes content_hash from the frontend SnapshotImage interface — it's an internal storage detail not needed by the UI
  • Stops filtering content_hash from the metadata copy-to-clipboard JSON (since the field is gone)
  • Filters out null values from the metadata JSON to reduce noise
  • Reorders dropdown menu items: Build Metadata → View Base Build → Download Images → Rerun Status Checks → Delete

Test plan

  • Open a snapshot detail page and verify the dropdown menu shows the new "Download Images" option
  • Click "Download Images" and confirm the zip downloads with the correct filename
  • Verify the metadata copy button no longer includes content_hash or null fields
  • Confirm existing snapshot stories still render correctly without content_hash

Copy link
Copy Markdown
Contributor Author

NicoHinderling commented May 11, 2026

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

📊 Type Coverage Diff

Metric Before After Delta
Coverage 93.47% 93.47% ±0%
Typed 134,857 134,863 🟢 +6
Untyped 9,424 9,425 🔴 +1
🔍 1 new type safety issue introduced

any-typed symbols (1 new)

File Line Detail
static/app/views/preprod/snapshots/header/snapshotHeaderActions.tsx 172 detail (var)

This is informational only and does not block the PR.

@NicoHinderling NicoHinderling marked this pull request as ready for review May 11, 2026 22:05
@NicoHinderling NicoHinderling requested a review from a team as a code owner May 11, 2026 22:05
Comment thread static/app/views/preprod/snapshots/header/snapshotHeaderActions.tsx Outdated
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_frontend_logic_for_downloading_images_zip branch from 929ed85 to 3f28b40 Compare May 11, 2026 22:08
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_endpoint_for_downloading_images_zip branch from 367ae5e to 1ebb99a Compare May 11, 2026 22:08
Comment thread static/app/views/preprod/snapshots/header/snapshotHeaderActions.tsx Outdated
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_endpoint_for_downloading_images_zip branch from 1ebb99a to 677bcff Compare May 11, 2026 22:36
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_frontend_logic_for_downloading_images_zip branch from 3f28b40 to 644152b Compare May 11, 2026 22:36
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 644152b. Configure here.

Comment thread static/app/views/preprod/snapshots/header/snapshotHeaderActions.tsx
Comment thread static/app/views/preprod/snapshots/header/snapshotHeaderActions.tsx Outdated
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_frontend_logic_for_downloading_images_zip branch from 644152b to d49718c Compare May 11, 2026 22:48
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_endpoint_for_downloading_images_zip branch from 5db78fd to 1c91f37 Compare May 11, 2026 23:36
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_frontend_logic_for_downloading_images_zip branch from d49718c to eb287dd Compare May 11, 2026 23:36
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_endpoint_for_downloading_images_zip branch from 1c91f37 to f9b8a7e Compare May 11, 2026 23:47
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_frontend_logic_for_downloading_images_zip branch from eb287dd to a02cf59 Compare May 11, 2026 23:47
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_frontend_logic_for_downloading_images_zip branch from a02cf59 to 2a8c99b Compare May 11, 2026 23:49
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_endpoint_for_downloading_images_zip branch from f9b8a7e to 80054f9 Compare May 11, 2026 23:50
Base automatically changed from 05-11-feat_snapshots_add_endpoint_for_downloading_images_zip to master May 12, 2026 02:29
@NicoHinderling NicoHinderling requested a review from a team as a code owner May 12, 2026 02:29
@NicoHinderling NicoHinderling requested a review from a team as a code owner May 12, 2026 02:29
@NicoHinderling NicoHinderling force-pushed the 05-11-feat_snapshots_add_frontend_logic_for_downloading_images_zip branch from 2a8c99b to 2e8193b Compare May 12, 2026 02:29
@NicoHinderling NicoHinderling merged commit 4a43ba6 into master May 12, 2026
76 checks passed
@NicoHinderling NicoHinderling deleted the 05-11-feat_snapshots_add_frontend_logic_for_downloading_images_zip branch May 12, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants