Skip to content

feat(ourlogs): add 'Group by attribute' to log property context menu#115420

Merged
JoshuaKGoldberg merged 5 commits into
masterfrom
log-property-context-menu-group-by
May 19, 2026
Merged

feat(ourlogs): add 'Group by attribute' to log property context menu#115420
JoshuaKGoldberg merged 5 commits into
masterfrom
log-property-context-menu-group-by

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 12, 2026

This also pipes through setSidebarOpen as a context value so that when the grouping is added, the sidebar opens to reveal it. ✨

image

Fixes LOGS-809.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.56%

@JoshuaKGoldberg JoshuaKGoldberg changed the title [Prototype] feat(ourlogs): add 'Group By' to log property context menu feat(ourlogs): add 'Group by attribute' to log property context menu May 15, 2026
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 15, 2026

LOGS-809

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 15, 2026 14:50
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner May 15, 2026 14:50
Comment thread static/app/views/explore/logs/useLogAttributesTreeActions.tsx
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft May 18, 2026 16:05
@JoshuaKGoldberg JoshuaKGoldberg merged commit ec0fdfa into master May 19, 2026
74 of 75 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the log-property-context-menu-group-by branch May 19, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants