fix(onboarding): Add missing logs/metrics snippets to JS onboarding variants#115425
Draft
cleptric wants to merge 3 commits into
Draft
fix(onboarding): Add missing logs/metrics snippets to JS onboarding variants#115425cleptric wants to merge 3 commits into
cleptric wants to merge 3 commits into
Conversation
The base JavaScript onboarding did not react to logs or metrics product selection changes, unlike all other JS framework variants (React, Angular, Vue, Svelte). Add enableLogs to init config, a logger example to the verify snippet, and logs next-step links for both loader-script and npm/yarn install modes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
…, TanStack Start Vue was missing logs in its verify snippet. SolidStart was missing enableLogs in both client and server init configs and metrics in nextSteps. TanStack Start was missing logs in its verify snippet and had no nextSteps at all. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cleptric
changed the title
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introduced
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several JavaScript onboarding variants did not update code snippets when
toggling the Logs or Metrics product selections, even though these products
are declared as available.
Base JavaScript (
javascript/utils.tsx)Init config was missing
enableLogs: true, verify snippet was missing aSentry.logger.info()example, and nextSteps was missing a Logsdocumentation link — for both loader-script and npm/yarn modes.
Vue (
javascript-vue/onboarding.tsx)Verify snippet was missing the logs code block (only had metrics).
SolidStart (
javascript-solidstart/)Client-side
getDynamicPartsand server-side init snippet were bothmissing
enableLogs: true. NextSteps was missing a metrics entry.TanStack Start (
javascript-tanstackstart-react/onboarding.tsx)Verify snippet was missing the logs code block. Had no
nextStepsfunction at all (no logs or metrics entries).