fix(api): Prevent AssertionError from oversized DSN project_id in error-page embed#115475
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(api): Prevent AssertionError from oversized DSN project_id in error-page embed#115475sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ProjectKey.from_dsnmethod, used by the/api/embed/error-page/endpoint, was extracting theproject_idfrom the DSN path and passing it directly toProjectKey.objects.get(). WhileValueErrorfor non-integer IDs was handled, a valid integer exceedingBoundedBigAutoField.MAX_VALUEwould trigger anAssertionErrorduring the ORM's preparation of the value.To fix this,
ProjectKey.from_dsnnow explicitly validates the extractedproject_id:project_idto an integer.BoundedBigAutoField.MAX_VALUE.project_idis invalid (non-integer, non-positive, or out-of-range), it raisesProjectKey.DoesNotExist.This ensures that the
AssertionErroris prevented, and invalid DSNs are gracefully handled by the calling endpoint, which already mapsProjectKey.DoesNotExistto a 404 response.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5H8J