ref(span-buffer): Remove flusher and buffer logger options#115487
Conversation
fpacifici
left a comment
There was a problem hiding this comment.
IF you remove the logger you also have to remove the script to parse them
- https://github.com/getsentry/sentry/tree/master/src/sentry/spans/log_analyzer
- docs https://github.com/getsentry/sentry/tree/master/src/sentry/spans#gcp-log-analyzer-tool
But, as I said below, I would not remove the buffer logger till we do not get rid of OTLP enrichment. We still have possible failure modes where specific traces can become problematic. Having the log and the log analyzer allow us to quickly identify the trace.
| return last_log_time | ||
|
|
||
|
|
||
| class BufferLogger: |
There was a problem hiding this comment.
I would not remove the buffer logger till we do not get rid of OTLP enrichment altogether.
There are still possible failure modes where we would want to identify a problematic trace.
Ok to remove the flusher one
There was a problem hiding this comment.
removed the flusher logger only.
37edf06 to
d9ae398
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d9ae398. Configure here.
Remove the FlusherLogger and its associated options while keeping the BufferLogger for identifying problematic traces during OTLP enrichment.
d9ae398 to
3c2ba59
Compare
|
have to revert this to investigate another instance of a single redis shard running hot |
|
revert failed (conflict? already reverted?) -- check the logs |
Backend Test FailuresFailures on
|

Summary
spans.buffer.flusher-cumulative-logger-enabledoption and FlusherLogger classspans.buffer.flusher.log-flushed-segmentsoption and associated loggingspans.buffer.evalsha-cumulative-logger-enabledoption and BufferLogger classThese logging options were used for debugging during development but are no longer needed.
Refs STREAM-881