Skip to content

fix(grouping): Parameterize error message fingerprint variables#115496

Merged
lobsterkatie merged 3 commits into
masterfrom
kmclb-parameterize-error-message-fingerprint-variable
May 15, 2026
Merged

fix(grouping): Parameterize error message fingerprint variables#115496
lobsterkatie merged 3 commits into
masterfrom
kmclb-parameterize-error-message-fingerprint-variable

Conversation

@lobsterkatie
Copy link
Copy Markdown
Member

@lobsterkatie lobsterkatie commented May 13, 2026

In our grouping algorithm, when using component-based grouping, we parameterize both log and error messages, but when using fingerprint-based grouping, we only parameterize log messages, an inadvertent difference in behavior.

This PR fixes that by extending parameterization to also include the two error message fingerprint variables, {{ value }} and {{ error.value }}. It also introduces two new variables, {{ raw_value }} and {{ error.raw_value }}, as analogs to the {{ raw_message }} variable, so that people can opt out of the parameterization if they choose to.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 13, 2026
@lobsterkatie lobsterkatie marked this pull request as ready for review May 15, 2026 19:04
@lobsterkatie lobsterkatie requested a review from a team as a code owner May 15, 2026 19:04
@lobsterkatie lobsterkatie merged commit 1e250b5 into master May 15, 2026
117 of 119 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-parameterize-error-message-fingerprint-variable branch May 15, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants