fix(avatar): add cached fallback to AsyncMemberAvatar#115554
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
natemoo-re
force-pushed
the
nm/fix/avatar-user
branch
from
83c0ba1 to
5c4b0ae
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.52% |
Restore the canRenderActor gate so AsyncMemberAvatar only fires a useMembers fetch when the sparse actor has no name or email. When a name is present, render the letter avatar immediately; the useMembers cache scan in findMembersInCache will still upgrade to the real avatar when the data is already loaded by another query. This prevents unmocked /members/ requests in tests and avoids showing a loading placeholder for named actors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
natemoo-re
force-pushed
the
nm/fix/avatar-user
branch
from
2a3f98c to
f407d12
Compare
JonasBa
approved these changes
May 14, 2026
natemoo-re
changed the title
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom user avatars (uploaded / gravatar) did not render in the assignee column of the issues feed.
ActorAvataralready handlesAsyncMemberAvatarinternally, but we have an opt-out mechanism whenactor.name || actor.emailexists, which happens in the issues feed.This PR simplifies that bypass and updates the
useMembershook to scan the query cache for users that may already have been fetched as sets it asinitialData. This allows theAsyncMemberAvatarto render the full avatar if it's already been fetched or fallback to the current behavior if not.Net result The issues feed now has user avatars as expected. Closes #115541.