feat(trace-waterfall): Small tweaks to trace-waterfall tab#115584
Merged
nsdeschenes merged 13 commits intoMay 19, 2026
Conversation
Render trace detail tabs from trace metadata counts when the endpoint provides them. This avoids waiting on tab-specific result sets before showing or hiding those sections. Keep legacy metadata paths falling back to loaded tab data where the count is not available. Co-Authored-By: Codex <noreply@openai.com>
Add application metrics to the trace detail header summary when metrics are present. Use trace metadata for the count and fall back to the loaded metrics count when needed. Co-Authored-By: Codex <noreply@openai.com>
Respect Logs and Application Metrics tab URLs while trace data is still loading. This lets each tab render its own loading state instead of briefly showing the trace waterfall placeholder. Co-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
Author
|
@cursor review |
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
Update the trace context section spec mocks to return node-shaped values from findChild. This keeps the test aligned with the TraceTree API and satisfies tsgo. Co-Authored-By: Codex <noreply@openai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 48fdebf. Configure here.
Keep the AI spans tab selected from the URL while trace metadata is loading, matching the behavior for logs and metrics tabs. Co-Authored-By: GPT-5.5 <noreply@example.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Keep AI span counts from legacy trace meta non-authoritative so legacy traces can still use tree-based AI node detection. Co-Authored-By: Codex <noreply@openai.com>
Keep trace logs and metrics tab visibility behind their existing product feature flags when using trace meta counts. Preserve tree-based AI span detection when trace meta has no gen_ai span op count, since the tab detects AI spans from gen_ai.operation.type. Co-Authored-By: Codex <noreply@openai.com>
Keep logs and metrics URL tabs from being preserved during loading when their product feature is disabled. This prevents loading-state tab selection from bypassing the trace tab feature gates. Co-Authored-By: Codex <noreply@openai.com>
Pass trace meta into the header section checks so logs-only traces do not render a placeholder while the logs tab is available. Use trace meta logs counts in the header before the logs array has loaded. Co-Authored-By: Codex <noreply@openai.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 22445db. Configure here.
When EAP trace metadata reports no logs or metrics, avoid preserving those URL tabs during tree loading. This keeps the selected tab aligned with the available tab options after metadata loads. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Treat the tab query param as usable only when query-string returns a scalar string. This keeps initial tab selection typed around the values it can compare against. Co-Authored-By: OpenAI Codex <codex@openai.com>
adrianviquez
approved these changes
May 19, 2026
nsdeschenes
deleted the
nd/feat-trace-waterfall-update-trace-waterfall-tabs
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render trace detail tabs from trace meta counts instead of waiting for each tab’s backing data to load. This lets Logs, Application Metrics, and AI appear earlier when trace meta already knows those sections have data, while preserving existing fallbacks for legacy meta responses.
Trace Tab Visibility
The trace tab list now uses
useTraceMetacounts for supported sections and falls back to loaded tab data where meta does not provide a definitive value. Logs and metrics still respect their product feature gates, and URL tab preservation during loading is also gated.Header Counts
The trace header now shows the Application Metrics count from trace meta and uses meta-backed Logs counts before logs have loaded. This keeps the header in sync with tab visibility for logs-only and metrics-backed traces.
AI Span Detection
AI tab visibility can use positive meta counts, but still falls back to tree-based detection so traces with AI spans identified by
gen_ai.operation.typeare not hidden whenspan.opcounts are incomplete.Closes EXP-927