fix(replays): correct query invalidation on refresh

[JoshuaKGoldberg]

I'm somewhat low confidence I've understood the current/new query key plumbing correct. But I think this corrects the doRefresh callback to properly clear the replay & replay-segments data?

Fixes REPLAY-910.

[linear-code]

REPLAY-910

[github-actions]

📊 Type Coverage Diff

Metric	Before	After	Delta
Coverage	93.60%	93.60%	±0%
Typed	135,662	135,666	🟢 +4
Untyped	9,269	9,270	🔴 +1

🔍 1 new type safety issue introduced

Non-null assertions (!) (1 new)

File	Line	Detail
static/app/components/replays/replayLiveIndicator.tsx	132	useReplayProjectSlug({replayRecord: replay})!

This is informational only and does not block the PR.

[JoshuaKGoldberg]

I don't like adding this !. But projectSlug is only used in places where it's defined...

[TkDodo]

I guess a test might be a good thing to add?

[TkDodo]

I thought one part of the problem was that we wouldn’t want to invalidate queries that are polling ? At least you had that in the previous solution. So wouldn’t we need to migrate this one to replayRecordApiOptions too:

sentry/static/app/utils/replays/hooks/usePollReplayRecord.tsx

Lines 20 to 28 in 0927cbc

	const queryKey: ApiQueryKey = [
	getApiUrl('/organizations/$organizationIdOrSlug/replays/$replayId/', {
	path: {organizationIdOrSlug: orgSlug, replayId},
	}),
	{
	// we use { isPolling: true } to avoid colliding with the queryKey used by useReplayData
	query: {isPolling: true},
	},
	];

and then make isPolling a required param to the function so that we only invalidate the ones were isPolling is false ?

[TkDodo]

we could accept string | undefined here as input for those ids and then use skipToken internally to avoid the type assertion

[JoshuaKGoldberg]

(talked 1:1) Existing code - I would love to refactor this, but since I'm just doing this as a spot fix for a virtual team, that'll have to be a followup. 😞