fix(releases): Pass Environment objects to get_latest_release#115637
Merged
Conversation
The releases list endpoint passed `filter_params["environment"]` (a list of environment name strings) to `get_latest_release` when resolving `release:latest` filters. `get_latest_release` expects `Sequence[Environment]` and dereferences `e.id` on each item, raising `AttributeError: 'str' object has no attribute 'id'` whenever the request also specified an environment. Switch to `filter_params["environment_objects"]`, which is populated alongside `environment` and contains the resolved Environment objects. Other call sites in this file correctly pass name strings to APIs that accept names, so they are unchanged. Fixes SENTRY-548A Co-Authored-By: Claude <noreply@anthropic.com>
JoshFerge
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The releases list endpoint passed
filter_params["environment"](a list of environment name strings) toget_latest_releasewhen resolvingrelease:latestfilters.get_latest_releaseexpectsSequence[Environment]and dereferencese.idon each item, raisingAttributeError: 'str' object has no attribute 'id'whenever the request also specified an environment.Switch to
filter_params["environment_objects"], which is populated alongsideenvironmentand contains the resolved Environment objects. Other call sites in this file correctly pass name strings to APIs that accept names, so they are unchanged.Fixes SENTRY-548A