fix(preprod): Change snapshot image tags from list to dict#115643
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
NicoHinderling
changed the title
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…tion The JSON schema generated by ImageMetadata.schema() rejected list-format tags before the Pydantic coerce_tags validator could run, breaking backward compatibility for clients still sending tags as a list. Add schema_extra to emit an anyOf that accepts both object and array formats, so jsonschema.validate passes and the Pydantic validator handles coercion. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8e37f3a. Configure here.
The schema_extra override dropped the null type for the optional tags field, causing jsonschema.validate to reject explicit "tags": null payloads. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
mtopo27
approved these changes
May 15, 2026
…xtra Mypy strict mode requires explicit type parameters for generic types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the
tagsfield on snapshot image metadata fromlist[str]todict[str, str], enabling key-value tag semantics (e.g.{"theme": "dark"}instead of["dark"]).ImageMetadataandSnapshotImageDetailImageInfotypes fromlist[str]todict[str, str]validatoronImageMetadata.tagsto gracefully coerce legacylistpayloads intodictform (["dark"] → {"dark": "dark"})This is a re-land of #115628, which was reverted and then re-applied with a test fix.