fix(tests): Use findByRole for async options in opJsonPath.spec.tsx#115645
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f93845b. Configure here.
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.53% |
ryan953
approved these changes
May 15, 2026
… findByRole
The previous fix converted the first getByRole('option', ...) call after
each dropdown click to await screen.findByRole(...), but left the paired
second option query synchronous in four test cases:
- 'shows < and > comparisons as disabled' – greaterThan
- 'enables < and > comparisons for numeric operand' – greaterThan
- 'shows string operand types as disabled' – Literal
- 'shows string operand types as enabled' – Literal
Since CompositeSelect renders options asynchronously, the sibling queries
are subject to the same race condition. Converting all option lookups to
findByRole makes the fix consistent and resilient to future rendering
behaviour changes.
Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR addresses JEST-22P5 by updating tests in
static/app/views/alerts/rules/uptime/assertions/opJsonPath.spec.tsx.The root cause was identified as a race condition where
screen.getByRole('option', ...)was called immediately afteruserEvent.click()on aCompositeSelecttrigger. TheCompositeSelectcomponent, which uses@sentry/scrapsand React Aria, renders its options asynchronously. This meant that the options were not always present in the DOM whengetByRolewas executed, leading to aTestingLibraryElementError.The fix involves replacing
screen.getByRole('option', ...)withawait screen.findByRole('option', ...)for the initial lookup of option elements after the dropdown trigger is clicked.findByRoleincludes built-in waiting and retrying logic, ensuring that the test waits for the asynchronous rendering of the options before attempting to query them, thus eliminating the flakiness.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JEST-22P5