fix(auth): Verify primary email on password reset#115651
Merged
Merged
Conversation
Completing a password reset proves the user controls the inbox the reset link was sent to. Move the verify_user_email call out of the relocate-only block so it runs for all recovery modes, matching the reasoning already documented for the relocation flow. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
nora-shap
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing a password reset proves the user controls the inbox the reset link was sent to. Move the verify_user_email call out of the relocate-only block so it runs for all recovery modes, matching the reasoning already documented for the relocation flow.
I've confirmed that the one potential exploit is not actually exploitable (user changes their primary email to another email before password reset completes, which verifies that other email instead of the one they sent). However, you can't promote an unverified email to primary, so we're safe.