Skip to content

ref(flags): Remove organizations:dashboards-import#115671

Merged
wedamija merged 1 commit into
masterfrom
flag-cleanup/organizations-dashboards-import
May 21, 2026
Merged

ref(flags): Remove organizations:dashboards-import#115671
wedamija merged 1 commit into
masterfrom
flag-cleanup/organizations-dashboards-import

Conversation

@wedamija
Copy link
Copy Markdown
Member

Dev-only flag registered Mar 2024, never rolled out to customers. Remove the flag registration and the unreleased gated code paths.

@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.54%

@wedamija wedamija marked this pull request as ready for review May 15, 2026 21:34
@wedamija wedamija requested a review from a team as a code owner May 15, 2026 21:34
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 925cc34. Configure here.

Comment thread static/app/views/dashboards/controls.tsx
Comment thread static/app/views/dashboards/manage/index.tsx
@wedamija wedamija force-pushed the flag-cleanup/organizations-dashboards-import branch from 925cc34 to 952a1aa Compare May 15, 2026 21:45
@wedamija wedamija force-pushed the flag-cleanup/organizations-dashboards-import branch from 952a1aa to b576552 Compare May 15, 2026 21:54
@wedamija wedamija requested a review from a team May 20, 2026 19:48
Copy link
Copy Markdown
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feature was created specifically for Solutions Engineering hence it hasn't been rolled out further than this. This feature will need to stick around but i'll move it to permanent.py so there's a distinction

@wedamija
Copy link
Copy Markdown
Member Author

this feature was created specifically for Solutions Engineering hence it hasn't been rolled out further than this. This feature will need to stick around but i'll move it to permanent.py so there's a distinction

Sounds good! I can also move it in this pr if you like

@nikkikapadia
Copy link
Copy Markdown
Member

this feature was created specifically for Solutions Engineering hence it hasn't been rolled out further than this. This feature will need to stick around but i'll move it to permanent.py so there's a distinction

Sounds good! I can also move it in this pr if you like

that would be great! thanks Dan 😌

Move from temporary.py to permanent.py's flagpole section. The flag
remains controllable via flagpole YAML config with api_expose=True,
but is now classified as a permanent feature.

No behavior change.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@wedamija wedamija force-pushed the flag-cleanup/organizations-dashboards-import branch from b576552 to c4d34e4 Compare May 21, 2026 20:19
@wedamija
Copy link
Copy Markdown
Member Author

@nikkikapadia No worries, done!

@wedamija wedamija requested a review from nikkikapadia May 21, 2026 20:40
Copy link
Copy Markdown
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@wedamija wedamija merged commit ab5681a into master May 21, 2026
83 checks passed
@wedamija wedamija deleted the flag-cleanup/organizations-dashboards-import branch May 21, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants