Skip to content

ref(flags): Remove organizations:ingest-through-trusted-relays-only#115682

Merged
wedamija merged 1 commit into
masterfrom
flag-cleanup/organizations-ingest-through-trusted-relays-only
May 20, 2026
Merged

ref(flags): Remove organizations:ingest-through-trusted-relays-only#115682
wedamija merged 1 commit into
masterfrom
flag-cleanup/organizations-ingest-through-trusted-relays-only

Conversation

@wedamija
Copy link
Copy Markdown
Member

Dev-only flag registered Jun 2025, never rolled out to customers. Remove the flag registration and the unreleased gated code paths.

@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.56%

@wedamija wedamija marked this pull request as ready for review May 15, 2026 21:34
@wedamija wedamija requested review from a team as code owners May 15, 2026 21:34
Comment thread static/app/views/settings/organizationRelay/relayWrapper.spec.tsx Outdated
Copy link
Copy Markdown
Member Author

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally sure if this is fine to remove, would appreciate if someone from @getsentry/ingest could take a look. If we want to keep it, I can move it to be a permanent flag instead

@wedamija wedamija force-pushed the flag-cleanup/organizations-ingest-through-trusted-relays-only branch from b6fa5ed to 3b7413f Compare May 15, 2026 22:00
Comment thread tests/relay_integration/test_integration.py Outdated
Comment thread src/sentry/core/endpoints/organization_details.py Outdated
@wedamija wedamija force-pushed the flag-cleanup/organizations-ingest-through-trusted-relays-only branch from 3b7413f to a496b65 Compare May 15, 2026 22:09
Comment thread src/sentry/relay/config/__init__.py
@wedamija wedamija force-pushed the flag-cleanup/organizations-ingest-through-trusted-relays-only branch from a496b65 to 2ff833c Compare May 15, 2026 22:18
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2ff833c. Configure here.

Comment thread src/sentry/core/endpoints/organization_details.py
Copy link
Copy Markdown
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was built as a customer was requesting it, but it is useful in general to all users of Relay. Due to staffing and other things, this was pretty much finished just never rolled out (honestly I thought it was already rolled out).

We should keep this around for now.

@wedamija wedamija force-pushed the flag-cleanup/organizations-ingest-through-trusted-relays-only branch from 2ff833c to fc84b60 Compare May 19, 2026 20:47
@wedamija wedamija force-pushed the flag-cleanup/organizations-ingest-through-trusted-relays-only branch from fc84b60 to 2ff833c Compare May 19, 2026 20:55
@wedamija
Copy link
Copy Markdown
Member Author

This was built as a customer was requesting it, but it is useful in general to all users of Relay. Due to staffing and other things, this was pretty much finished just never rolled out (honestly I thought it was already rolled out).

We should keep this around for now.

@Dav1dde Ok, should I make this a permanent feature flag, or just set the flag scanner to ignore it for 6 months or so?

@Dav1dde
Copy link
Copy Markdown
Member

Dav1dde commented May 20, 2026

@wedamija if you have the cycles to make it permanent, that'd be amazing

…permanent

Move from temporary.py to permanent.py's flagpole section. The flag
remains controllable via flagpole YAML config with api_expose=True,
but is now classified as a permanent feature.

No behavior change.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@wedamija wedamija force-pushed the flag-cleanup/organizations-ingest-through-trusted-relays-only branch from 2ff833c to 0499292 Compare May 20, 2026 16:22
Copy link
Copy Markdown
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@wedamija wedamija merged commit c2b3c1c into master May 20, 2026
83 checks passed
@wedamija wedamija deleted the flag-cleanup/organizations-ingest-through-trusted-relays-only branch May 20, 2026 19:47
JonasBa pushed a commit that referenced this pull request May 21, 2026
…115682)

Dev-only flag registered Jun 2025, never rolled out to customers. Remove the flag registration and the unreleased gated code paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants