ref(replays): use shared platform icon resolver#115705
Merged
priscilawebdev merged 1 commit intoMay 21, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
Base automatically changed from
priscilawebdev/ref/de-1262-migrate-contexticon-to-platformicons
to
master
May 19, 2026 09:30
Delegate generatePlatformIconName to getLogoImage (LOGO_MAPPING in contextIcon) instead of keeping a parallel PLATFORM_ALIASES map. Drops the duplicated alias table and the @ts-expect-error escape. Note: this consolidates onto the canonical events-context mapping, which differs in a few edge cases (e.g. 'ipod' -> 'apple-iphone'). For browser/OS strings produced by replay SDKs these names are unlikely to surface.
priscilawebdev
force-pushed
the
priscilawebdev/ref/consolidate-replay-platform-icon-resolution
branch
from
1a58a0c to
0e8b3ea
Compare
TkDodo
approved these changes
May 20, 2026
priscilawebdev
deleted the
priscilawebdev/ref/consolidate-replay-platform-icon-resolution
branch
JonasBa
pushed a commit
that referenced
this pull request
May 21, 2026
Stacked on #115701. `generatePlatformIconName` used to maintain its own `PLATFORM_ALIASES` table — a strict subset of `LOGO_MAPPING` in `contextIcon.tsx`, kept in sync by hand. With the migration to platformicons, the canonical mapping now lives in `getLogoImage`. This change drops the duplicate table and delegates to `getLogoImage`, also clearing the `@ts-expect-error` from the previous keyed access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #115701.
generatePlatformIconNameused to maintain its ownPLATFORM_ALIASEStable — a strict subset ofLOGO_MAPPINGincontextIcon.tsx, kept in sync by hand. With the migration to platformicons, the canonical mapping now lives ingetLogoImage. This change drops the duplicate table and delegates togetLogoImage, also clearing the@ts-expect-errorfrom the previous keyed access.