fix(ui): Convert TimePicker to controlled component to fix Safari reload#115711
Open
sjpriest wants to merge 1 commit into
Open
fix(ui): Convert TimePicker to controlled component to fix Safari reload#115711sjpriest wants to merge 1 commit into
sjpriest wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari fires
blurbeforechangeon<input type="time">, while Chrome fireschangefirst. The old class-basedTimePickerused ashouldComponentUpdateguard that blocked re-renders while focused, combined withkey={value}which unmounts/remounts the input on value changes. In Safari, the blur-first ordering caused the input to be destroyed and recreated mid-interaction, triggering unexpected page reloads.Controlled component rewrite
Converts
TimePickerfrom a class component usingshouldComponentUpdate+key+defaultValue(uncontrolled) to a functional component usinguseState+useEffect+value(controlled). Local state tracks input values and syncs from parent props, eliminating the event-ordering race entirely.Manually verified the fix in Safari (where the bug reproduced) and Chrome (no regression).